Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(graph): populate buildnumber on model #741

Merged
merged 2 commits into from
Nov 8, 2023
Merged

fix(graph): populate buildnumber on model #741

merged 2 commits into from
Nov 8, 2023

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Nov 6, 2023

fixes the following issue:

  1. hard load graph page
  2. click on step link
  3. unexpand the step log on the resulting page (or expand any other step)
  4. 400 error because build number was missing in request

this fix makes sure the buildNumber field is populated when you enter the site on a graph page

@wass3r wass3r requested a review from a team as a code owner November 6, 2023 23:31
ecrupper
ecrupper previously approved these changes Nov 7, 2023
View reviewed changes
plyr4
plyr4 previously approved these changes Nov 7, 2023
View reviewed changes
@wass3r wass3r dismissed stale reviews from plyr4 and ecrupper via a1f6b90 November 7, 2023 22:21
@plyr4 plyr4 merged commit e5a6e2a into main Nov 8, 2023
12 checks passed
@plyr4 plyr4 deleted the fix/graph/buildnumber branch November 8, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plyr4 plyr4 plyr4 approved these changes

@timhuynh94 timhuynh94 timhuynh94 approved these changes

@ecrupper ecrupper ecrupper left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wass3r @timhuynh94 @plyr4 @ecrupper