enhance(cancel): improve msg label for cancel events #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spent some time to look at "autocanceled" vs "auto canceled" vs "auto-canceled", the latter of which i prefer most but there seems to be no concrete rules around this, so i left it as-is (and it avoids having to update the server component) that returns the actual error message).
ecrupper
previously approved these changes
Nov 6, 2023
plyr4
previously approved these changes
Nov 6, 2023
plyr4
approved these changes
Nov 6, 2023
ecrupper
approved these changes
Nov 6, 2023
timhuynh94
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small pr to improve message labeling for cancel events. canceled builds will either get a
canceled:orauto canceled:message label.also prefixes
#to the build link for increased click area, especially for single digit builds.example for "auto canceled" status:
before:
after:
also spent some time to look at "autocanceled" vs "auto canceled" vs "auto-canceled", the latter of which i prefer most but there seems to be no concrete rules around this, so i left it as-is (and it avoids having to update the server component that returns the actual error message).