Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: various small tweaks #694

Merged
merged 4 commits into from
Jul 11, 2023
Merged

refactor: various small tweaks #694

merged 4 commits into from
Jul 11, 2023

Conversation

wass3rw3rk
Copy link
Member

@wass3rw3rk wass3rw3rk commented Jul 10, 2023 •
edited by wass3r
Loading

found via elm-review:

  • a few simplifications
  • some let..in movements to bring them closer to where it's actually used
  • avoid cmd.batch for single function calls
  • unnecessary variable assignments

@wass3rw3rk wass3rw3rk requested a review from a team as a code owner July 10, 2023 21:32
@wass3rw3rk wass3rw3rk merged commit 6335654 into main Jul 11, 2023
@wass3rw3rk wass3rw3rk deleted the chore/minor-fixes branch July 11, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecrupper ecrupper ecrupper approved these changes

@timhuynh94 timhuynh94 timhuynh94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wass3rw3rk @timhuynh94 @ecrupper @plyr4