Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify and remove unused #681

Merged
merged 3 commits into from
Jun 21, 2023
Merged

fix: simplify and remove unused #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdd873e
enhance: simplify code
wass3rw3rk Jun 20, 2023
17b0460
fix: remove unused code
wass3rw3rk Jun 20, 2023
30d5f06
fix formatting
wass3rw3rk Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/elm/Pages/Build/View.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,7 @@ viewBuildServices model msgs org repo buildNumber =
viewService : PartialModel a -> Msgs msg -> RepoModel -> Service -> Html msg
viewService model msgs rm service =
div
[ serviceClasses
[ class "service"
, Util.testAttribute "service"
]
[ div [ class "-status" ]
Expand All @@ -604,13 +604,6 @@ viewService model msgs rm service =
]


{-| serviceClasses : returns css classes for a particular service
-}
serviceClasses : Html.Attribute msg
serviceClasses =
classList [ ( "service", True ) ]


{-| viewServiceDetails : renders build services detailed information
-}
viewServiceDetails : PartialModel a -> Msgs msg -> RepoModel -> Service -> Html msg
Expand Down Expand Up @@ -875,13 +868,12 @@ viewLogLinks chunk =
splitIntersperseConcat : String -> List String -> List String
splitIntersperseConcat sep list =
list
|> List.map
|> List.concatMap
(\x ->
x
|> String.split sep
|> List.intersperse sep
)
|> List.concat

-- split the "line" by escape characters
split =
Expand Down
18 changes: 0 additions & 18 deletions src/elm/Pages/Schedules/Form.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ Use of this source code is governed by the LICENSE file in this repository.
module Pages.Schedules.Form exposing
( viewEnabledCheckbox
, viewHelp
, viewInput
, viewNameInput
, viewSubmitButtons
, viewValueInput
Expand Down Expand Up @@ -73,23 +72,6 @@ viewNameInput val disable =
]


{-| viewInput : renders value input box
-}
viewInput : String -> String -> String -> Html Msg
viewInput name val placeholder_ =
section [ class "form-control", class "-stack" ]
[ label [ class "form-label", for <| name ] [ strong [] [ text name ] ]
, input
[ value val
, onInput <| OnChangeStringField name
, class "schedule-name"
, placeholder placeholder_
, id name
]
[]
]


{-| viewValueInput : renders value input box
-}
viewValueInput : String -> String -> Html Msg
Expand Down
2 changes: 0 additions & 2 deletions src/elm/Pages/Schedules/Update.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ Use of this source code is governed by the LICENSE file in this repository.

module Pages.Schedules.Update exposing
( init
, onChangeEnable
, onChangeStringField
, reinitializeScheduleAdd
, reinitializeScheduleUpdate
, update
Expand Down
1 change: 0 additions & 1 deletion src/elm/Pages/Schedules/View.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ import Vela
, Schedule
, Schedules
, SchedulesModel
, SecretType(..)
)


Expand Down