Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: schedules consistent style #678

Merged
merged 8 commits into from
Jun 15, 2023
Merged

enhance: schedules consistent style #678

merged 8 commits into from
Jun 15, 2023

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Jun 15, 2023 •
edited
Loading

  • adds a header for "Add Schedule" and "View/Edit Schedule"
  • applies consistent form styling to make the page look more like the other "add" pages
  • removed default name for schedules purely for consistency, i can see it being useful to denote that 0 0 * * is a daily schedule but i think its confusing

before

Screenshot 2023-06-15 at 10 34 50 AM

after

Screenshot 2023-06-15 at 10 25 59 AM

"Add Secrets" for reference

Screenshot 2023-06-15 at 10 26 08 AM

@plyr4 plyr4 requested a review from a team as a code owner June 15, 2023 15:37
@plyr4 plyr4 changed the title enhance/schedules consistent style enhance: schedules consistent style Jun 15, 2023
@plyr4 plyr4 merged commit 51ddbed into main Jun 15, 2023
@plyr4 plyr4 deleted the enhance/schedules-consistent-style branch June 15, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecrupper ecrupper ecrupper approved these changes

@wass3rw3rk wass3rw3rk wass3rw3rk approved these changes

@timhuynh94 timhuynh94 timhuynh94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plyr4 @timhuynh94 @wass3rw3rk @ecrupper