Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(secrets): large names and general table render improvements #674

Merged
merged 13 commits into from
Jun 16, 2023

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Jun 9, 2023

pretty straightforward improvement to the way the table-base class renders secrets

  • adds a .secret-name class that sets a max-width of 15rem. this helps fix the cutoff issue from large secrets
  • renders "list cells" like images and events in a stack. this helps with the cutoff and makes images/events easier to read
  • renders key and the "list cell elements" inside <span> elements to make them easy to copy/scroll. they are also given a max-width to help with the cutoff issues
  • changes no images to all images to make it more clear what each secret is enabled for
  • reuses the -icon class to make the table icon tighter

before

(notice cutoff from the large secret name)

Screenshot 2023-06-09 at 3 31 56 PM

after

Screenshot 2023-06-09 at 3 30 39 PM

@plyr4 plyr4 requested a review from a team as a code owner June 9, 2023 20:23
@plyr4 plyr4 marked this pull request as draft June 9, 2023 20:23
@plyr4 plyr4 changed the title fix/tables cutoff fix(secrets): large names and general table render improvements Jun 9, 2023
@plyr4 plyr4 marked this pull request as ready for review June 9, 2023 20:37
@plyr4 plyr4 self-assigned this Jun 9, 2023
@plyr4
Copy link
Contributor Author

plyr4 commented Jun 13, 2023

per feedback im going to look into converting the <input> to a styled scrollable <span>

@plyr4 plyr4 marked this pull request as draft June 13, 2023 15:27
@plyr4 plyr4 marked this pull request as ready for review June 15, 2023 14:35
@plyr4
Copy link
Contributor Author

plyr4 commented Jun 15, 2023

converted the readonly <input> elements to <span> with overflow: scroll
RFR

@plyr4 plyr4 merged commit efcdeb3 into main Jun 16, 2023
@plyr4 plyr4 deleted the fix/tables-cutoff branch June 16, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants