Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused helper function #671

Merged
merged 4 commits into from
Jun 13, 2023
Merged

refactor: remove unused helper function #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b0011a
refactor: remove redundant code
plyr4 Jun 9, 2023
19159d8
refactor: remove redundant code
plyr4 Jun 9, 2023
48ed60a
Merge branch 'main' into refactor/unused-deployment-form
plyr4 Jun 13, 2023
07ab63f
Merge branch 'main' into refactor/unused-deployment-form
plyr4 Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/elm/Main.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2586,7 +2586,7 @@ viewContent model =

Pages.PromoteDeployment org repo buildNumber ->
( String.join "/" [ org, repo, buildNumber ] ++ " promote deployment"
, Html.map AddDeploymentUpdate <| lazy Pages.Deployments.View.promoteDeployment model
, Html.map AddDeploymentUpdate <| lazy Pages.Deployments.View.addDeployment model
)

Pages.RepositoryDeployments org repo maybePage _ ->
Expand Down
17 changes: 1 addition & 16 deletions src/elm/Pages/Deployments/View.elm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Use of this source code is governed by the LICENSE file in this repository.
--}


module Pages.Deployments.View exposing (addDeployment, promoteDeployment, viewDeployments)
module Pages.Deployments.View exposing (addDeployment, viewDeployments)

import Errors exposing (viewResourceError)
import FeatherIcons
Expand Down Expand Up @@ -167,18 +167,3 @@ viewDeployments deploymentsModel org repo =

RemoteData.Failure _ ->
viewResourceError { resourceLabel = "deployments for this repository", testLabel = "deployments" }



-- Promote Deployment


{-| promoteDeployment : takes partial model and renders deployment form for promoting a deployment
-}
promoteDeployment : PartialModel a msg -> Html Msg
promoteDeployment model =
div [ class "manage-deployment", Util.testAttribute "add-deployment" ]
[ div []
[ addForm model.deploymentModel
]
]