fix: remove tabs from add-deployment #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
im going to invert the implementation and try out adding the tabs to ALL "add" resource pages and see what it looks like |
|
tried it, and with the expanded crumbs introduced in #669 the pages become very busy it also becomes difficult to track which tabs should redirect where, because a highlighted "Secrets" tab for example could lead you to repo secrets, or move you nowhere. to quote someone else, if we introduced bigger changes and reworked crumbs again then i think tabs and "add" resource pages could work well together, but not now |
|
im continuing with the original plan, removing tabs from the "add resource" pages, Deployments is the only one needing the fix RFR |
ecrupper
approved these changes
Jun 15, 2023
wass3rw3rk
approved these changes
Jun 15, 2023
timhuynh94
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this removes the repo tabs from the "Add Deployment" page.
they arent supposed to be rendered on the resource-add pages. and if they are, then changes need to be made to make the tab actually highlight the resource (see the screenshot, no highlighting, and its the only resource-add page with the tabs)
it also adds the other pages and removes the switch short circuit (
_ ->) for more type safety, to help catch this easier in the future when more pages are added.before
after
other subpage for reference (no tabs)