chore(node): bump node and simplify ci #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wass3r
commented
Feb 16, 2022
| @@ -8,11 +8,9 @@ name: ci | |||
| # trigger on pull_request or push events | |||
| on: | |||
| push: | |||
| branches: | |||
There was a problem hiding this comment.
yaml validation didn't like this and this change would make this action consistent with what we do elsewhere, eg. https://github.com/go-vela/server/blob/ea8fadd3c76883df252fb3c3b60681deebd85e79/.github/workflows/test.yml#L4-L7
dtanner
approved these changes
Feb 17, 2022
plyr4
pushed a commit
that referenced
this pull request
Aug 19, 2022
plyr4
pushed a commit
that referenced
this pull request
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bumps node version to keep in line with #511
also simplifies Github Actions flow to pull node version from nvmrc in root of project instead of defining separately in each action