Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused #481

Merged
merged 2 commits into from
Nov 30, 2021
Merged

refactor: remove unused #481

merged 2 commits into from
Nov 30, 2021

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Nov 25, 2021

simply going through and removing unused bits with help from elm-review-unused.

if there's any strong feelings for any of it to be kept, feel free to comment.

@wass3r wass3r requested a review from a team as a code owner November 25, 2021 11:36
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4
Copy link
Contributor

plyr4 commented Nov 30, 2021

a few things will be re-introduced when Home page refactors are prioritized (like getAllRepos and maybe Warning alerts) but this is great 👍

@wass3r
Copy link
Collaborator Author

wass3r commented Nov 30, 2021

a few things will be re-introduced when Home page refactors are prioritized (like getAllRepos and maybe Warning alerts) but this is great 👍

Yup, should be easy to look back this PR and pull things back out.

@wass3r wass3r merged commit 7d706b5 into master Nov 30, 2021
@wass3r wass3r deleted the refactor/remove-unused branch November 30, 2021 14:49
plyr4 pushed a commit that referenced this pull request Aug 19, 2022
plyr4 pushed a commit that referenced this pull request Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants