Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump stylelint and related dependencies #471

Merged
merged 5 commits into from
Nov 3, 2021
Merged

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Nov 2, 2021

takes care of:
#465
#463
#462
#461

quite a few changes to the package-lock file due to npm7 (https://blog.npmjs.org/post/621733939456933888/npm-v7-series-why-keep-package-lockjson.html). supposed to help with "ensuring deterministically reproducible builds". to be clear, the lock file change technically came from this PR but the lock file got updated with the changes in this PR.

also of note, this adds postcss and autoprefixer to the dependencies, though they are only used dynamically by parcel. the cypress tests wouldn't run without them explicitly part of package.json.

@wass3r wass3r requested a review from a team as a code owner November 2, 2021 05:31
postcss and autoprefixer are dynamic dependencies
used by parcel
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wass3r wass3r merged commit 4939867 into master Nov 3, 2021
@wass3r wass3r deleted the chore/stylelint branch November 3, 2021 16:36
plyr4 pushed a commit that referenced this pull request Aug 19, 2022
* chore(deps): bump stylelint and related dependencies

* fix: pin postcss package

* fix: pin autoprefixer package

* fix(deps): remove postcss and autoprefixer

postcss and autoprefixer are dynamic dependencies
used by parcel

* Revert "fix(deps): remove postcss and autoprefixer"

This reverts commit f5fc50d.
plyr4 pushed a commit that referenced this pull request Aug 19, 2022
* chore(deps): bump stylelint and related dependencies

* fix: pin postcss package

* fix: pin autoprefixer package

* fix(deps): remove postcss and autoprefixer

postcss and autoprefixer are dynamic dependencies
used by parcel

* Revert "fix(deps): remove postcss and autoprefixer"

This reverts commit f5fc50d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Indicates a change to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants