refactor: clean up imports and RemoteData

src/elm/Auth.elm

@@ -10,7 +10,6 @@ import Auth.Session exposing (Session(..))
 import Dict
 import Route exposing (Route)
 import Route.Path
-import Route.Query
 import Shared
 import View exposing (View)
 

src/elm/Components/Build.elm

@@ -1,13 +1,10 @@
 module Components.Build exposing (..)
 
-import Ansi
-import Ansi.Log
 import Components.Svgs
 import DateFormat.Relative
 import FeatherIcons
-import Html exposing (Html, a, details, div, input, label, li, span, strong, summary, text, ul)
-import Html.Attributes exposing (attribute, checked, class, classList, for, href, id, name, style, title, type_)
-import Html.Events exposing (onClick)
+import Html exposing (Html, a, details, div, label, li, span, strong, summary, text, ul)
+import Html.Attributes exposing (attribute, class, classList, href, id, title)
 import List.Extra
 import RemoteData exposing (WebData)
 import Route.Path

src/elm/Components/Builds.elm

@@ -1,17 +1,12 @@
 module Components.Builds exposing (view, viewHeader)
 
-import Ansi
-import Ansi.Log
 import Components.Build
-import DateFormat.Relative exposing (relativeTime)
-import FeatherIcons
 import Html
     exposing
         ( Html
         , a
         , br
         , code
-        , details
         , div
         , em
         , h1
@@ -20,38 +15,24 @@ import Html
         , li
         , ol
         , p
-        , span
-        , strong
-        , summary
-        , table
-        , td
         , text
-        , tr
-        , ul
         )
 import Html.Attributes
     exposing
         ( attribute
         , checked
         , class
-        , classList
         , for
         , href
         , id
         , name
-        , style
-        , title
         , type_
         )
 import Html.Events exposing (onClick)
-import List.Extra
 import RemoteData exposing (WebData)
-import Route.Path
 import Shared
 import String
-import Time
-import Utils.Errors as Errors
-import Utils.Helpers as Util exposing (getNameFromRef)
+import Utils.Helpers as Util
 import Vela
 
 

src/elm/Components/Favorites.elm

@@ -10,7 +10,7 @@ import Html exposing (Html, button)
 import Html.Attributes exposing (attribute, class)
 import Html.Events exposing (onClick)
 import List.Extra
-import RemoteData exposing (RemoteData(..), WebData)
+import RemoteData exposing (WebData)
 import Utils.Helpers as Util
 import Vela
 
@@ -79,7 +79,7 @@ isFavorited user favorite =
 toggleFavorite : WebData Vela.CurrentUser -> String -> ( List String, Bool )
 toggleFavorite user favorite =
     case user of
-        Success u ->
+        RemoteData.Success u ->
             let
                 favorited =
                     List.member favorite u.favorites
@@ -102,7 +102,7 @@ toggleFavorite user favorite =
 addFavorite : WebData Vela.CurrentUser -> String -> ( List String, Bool )
 addFavorite user favorite =
     case user of
-        Success u ->
+        RemoteData.Success u ->
             let
                 favorites =
                     List.Extra.unique <| favorite :: u.favorites

src/elm/Components/Nav.elm

@@ -21,7 +21,7 @@ import Html.Attributes
         , classList
         )
 import Html.Events exposing (onClick)
-import RemoteData exposing (RemoteData(..), WebData)
+import RemoteData exposing (WebData)
 import Route exposing (Route)
 import Shared
 import Utils.Helpers as Util

src/elm/Components/RecentBuilds.elm

@@ -2,7 +2,7 @@ module Components.RecentBuilds exposing (..)
 
 import Components.Svgs
 import Html exposing (Html, a, div, em, li, p, span, text, ul)
-import Html.Attributes exposing (attribute, class, href)
+import Html.Attributes exposing (attribute, class)
 import RemoteData exposing (WebData)
 import Route.Path
 import Shared

src/elm/Components/Secrets.elm

@@ -6,11 +6,9 @@ import Html exposing (Html, a, button, div, span, td, text, tr)
 import Html.Attributes exposing (attribute, class, scope)
 import Html.Events exposing (onClick)
 import Http
-import Maybe.Extra
 import RemoteData exposing (WebData)
 import Route.Path
 import Shared
-import Url
 import Utils.Helpers as Util
 import Vela
 

src/elm/Components/Tabs.elm

@@ -3,11 +3,10 @@ module Components.Tabs exposing (Tab, view, viewBuildTabs, viewOrgTabs, viewRepo
 import Api.Pagination as Pagination
 import Html exposing (Html, a, div, span, text)
 import Html.Attributes exposing (class, classList)
-import RemoteData exposing (WebData)
+import RemoteData
 import Route.Path
 import Shared
 import Utils.Helpers as Util
-import Vela
 
 
 {-| Tab : record to represent information used by page navigation tab

src/elm/Layouts/Default.elm

@@ -5,7 +5,7 @@ SPDX-License-Identifier: Apache-2.0
 
 module Layouts.Default exposing (Model, Msg, Props, layout, map)
 
-import Components.Alerts as Alerts exposing (Alert)
+import Components.Alerts exposing (Alert)
 import Components.Footer
 import Components.Header
 import Components.Nav

src/elm/Layouts/Default/Build.elm

@@ -9,7 +9,7 @@ import Components.Build
 import Components.RecentBuilds
 import Components.Tabs
 import Effect exposing (Effect)
-import Html exposing (..)
+import Html exposing (Html)
 import Http
 import Http.Detailed
 import Layout exposing (Layout)

src/elm/Layouts/Default/Repo.elm

@@ -10,10 +10,8 @@ import Effect exposing (Effect)
 import Html exposing (..)
 import Layout exposing (Layout)
 import Layouts.Default
-import RemoteData exposing (WebData)
 import Route exposing (Route)
 import Shared
-import Vela
 import View exposing (View)
 
 

src/elm/Main.elm

@@ -1,9 +1,6 @@
 {--
 SPDX-License-Identifier: Apache-2.0
 --}
---todo: known issues:
--- favicon fails to load sometimes on fresh visit
--- not found redirects are weird, refreshing 404 goes to the home page?
 
 
 module Main exposing (main)

src/elm/Pages/Account/Login.elm

@@ -16,7 +16,6 @@ import Html
         , div
         , h1
         , p
-        , span
         , text
         )
 import Html.Attributes
@@ -27,7 +26,6 @@ import Html.Attributes
 import Html.Events exposing (onClick)
 import Layouts
 import Page exposing (Page)
-import RemoteData exposing (RemoteData(..), WebData)
 import Route exposing (Route)
 import Shared
 import Utils.Helpers as Util
@@ -90,8 +88,6 @@ update shared msg model =
             )
 
         SignInRequested ->
-            -- Login on server needs to accept redirect URL and pass it along to as part of 'state' encoded as base64
-            -- so we can parse it when the source provider redirects back to the API
             ( model
             , (Browser.Navigation.load <| Api.Endpoint.toUrl shared.velaAPI Api.Endpoint.Login) |> Effect.sendCmd
             )
@@ -110,8 +106,6 @@ subscriptions model =
 -- VIEW
 
 
-{-| view : takes current user, user input and action params and renders home page with favorited repos
--}
 view : Shared.Model -> Model -> View Msg
 view shared model =
     let

src/elm/Pages/Account/SourceRepos.elm

@@ -46,7 +46,7 @@ import Http.Detailed
 import Layouts
 import List.Extra
 import Page exposing (Page)
-import RemoteData exposing (RemoteData(..), WebData)
+import RemoteData exposing (WebData)
 import Route exposing (Route)
 import Shared
 import Utils.Errors as Errors
@@ -80,11 +80,11 @@ toLayout user shared model =
                     , ( "-outline", True )
                     ]
                 , onClick (GetUserSourceRepos True)
-                , disabled (model.sourceRepos == Loading)
+                , disabled (model.sourceRepos == RemoteData.Loading)
                 , Util.testAttribute "refresh-source-repos"
                 ]
                 [ case model.sourceRepos of
-                    Loading ->
+                    RemoteData.Loading ->
                         text "Loading…"
 
                     _ ->
@@ -108,7 +108,7 @@ type alias Model =
 init : () -> ( Model, Effect Msg )
 init () =
     ( { searchFilters = Dict.empty
-      , sourceRepos = NotAsked
+      , sourceRepos = RemoteData.NotAsked
       }
     , Effect.batch
         [ Effect.getCurrentUser {}
@@ -143,8 +143,8 @@ update shared msg model =
         GetUserSourceRepos isReload ->
             ( { model
                 | sourceRepos =
-                    if isReload || model.sourceRepos == NotAsked then
-                        Loading
+                    if isReload || model.sourceRepos == RemoteData.NotAsked then
+                        RemoteData.Loading
 
                     else
                         model.sourceRepos
@@ -186,7 +186,7 @@ update shared msg model =
 
         EnableRepo repo ->
             ( { model
-                | sourceRepos = Vela.enableUpdate repo Loading model.sourceRepos
+                | sourceRepos = Vela.enableUpdate repo RemoteData.Loading model.sourceRepos
 
                 -- todo: need this moved to the repo settings page
                 -- , repo = updateRepoEnabling Vela.Enabling rm
@@ -253,8 +253,6 @@ subscriptions model =
 -- VIEW
 
 
-{-| view : takes current user with repos fetched from source control
--}
 view : Shared.Model -> Model -> View Msg
 view shared model =
     let

src/elm/Pages/Home.elm

@@ -36,7 +36,7 @@ import Layouts
 import List
 import List.Extra
 import Page exposing (Page)
-import RemoteData exposing (RemoteData(..))
+import RemoteData
 import Route exposing (Route)
 import Route.Path
 import Shared
@@ -135,15 +135,13 @@ subscriptions model =
 -- VIEW
 
 
-{-| view : takes current user, user input and action params and renders home page with favorited repos
--}
 view : Shared.Model -> Model -> View Msg
 view shared model =
     { title = "Home"
     , body =
         [ div [ Util.testAttribute "overview" ] <|
             case shared.user of
-                Success u ->
+                RemoteData.Success u ->
                     if List.length u.favorites > 0 then
                         [ homeSearchBar model.favoritesFilter SearchFavorites
                         , viewFavorites u.favorites model.favoritesFilter
@@ -162,17 +160,10 @@ view shared model =
                             ]
                         ]
 
-                Loading ->
-                    [ h1 [] [ Util.largeLoader ] ]
-
-                NotAsked ->
+                _ ->
                     [ homeSearchBar model.favoritesFilter SearchFavorites
                     , viewFavorites [] model.favoritesFilter
                     ]
-
-                -- [ text "not asked" ]
-                Failure _ ->
-                    [ text "failed" ]
         ]
     }
 

src/elm/Pages/NotFound_.elm

@@ -82,8 +82,6 @@ subscriptions model =
 -- VIEW
 
 
-{-| view : takes current user, user input and action params and renders home page with favorited repos
--}
 view : Shared.Model -> Model -> View Msg
 view shared model =
     { title = "Not Found"

src/elm/Pages/Org_/Builds.elm

@@ -12,15 +12,14 @@ import Components.Builds
 import Components.Pager
 import Dict
 import Effect exposing (Effect)
-import Html exposing (text)
 import Http
 import Http.Detailed
 import Layouts
 import LinkHeader exposing (WebLink)
 import List
 import Maybe.Extra
 import Page exposing (Page)
-import RemoteData exposing (RemoteData(..), WebData)
+import RemoteData exposing (WebData)
 import Route exposing (Route)
 import Shared
 import Utils.Errors as Errors

src/elm/Pages/Org_/Repo_.elm

@@ -19,7 +19,6 @@ import LinkHeader exposing (WebLink)
 import List
 import Maybe.Extra
 import Page exposing (Page)
-import RemoteData exposing (RemoteData(..))
 import Route exposing (Route)
 import Shared
 import Utils.Helpers as Util

src/elm/Pages/Org_/Repo_/Audit.elm

@@ -39,12 +39,11 @@ import Layouts
 import LinkHeader exposing (WebLink)
 import List
 import Page exposing (Page)
-import RemoteData exposing (RemoteData(..), WebData)
+import RemoteData exposing (WebData)
 import Route exposing (Route)
 import Shared
 import Time
 import Utils.Ansi
-import Utils.Errors as Errors
 import Utils.Helpers as Util
 import Vela
 import View exposing (View)

src/elm/Pages/Org_/Repo_/Build_.elm

@@ -20,7 +20,7 @@ import Http.Detailed
 import Layouts
 import List.Extra
 import Page exposing (Page)
-import RemoteData exposing (RemoteData(..), WebData)
+import RemoteData exposing (WebData)
 import Route exposing (Route)
 import Route.Path
 import Shared

src/elm/Pages/Org_/Repo_/Build_/Graph.elm

@@ -20,7 +20,7 @@ import Http.Detailed
 import Layouts
 import List.Extra
 import Page exposing (Page)
-import RemoteData exposing (RemoteData(..), WebData)
+import RemoteData exposing (WebData)
 import Route exposing (Route)
 import Route.Path
 import Shared