Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: library swap to goccy #144

Merged
merged 2 commits into from
Feb 4, 2021
Merged

revert: library swap to goccy #144

merged 2 commits into from
Feb 4, 2021

Conversation

kneal
Copy link

@kneal kneal commented Feb 4, 2021

This swap reverts us back to the state of tag v0.6.0 for types.

PRs used as reference:

#118
#126
#12

@kneal kneal added the bug Indicates a bug label Feb 4, 2021
@kneal kneal self-assigned this Feb 4, 2021
@kneal kneal requested a review from a team as a code owner February 4, 2021 15:16
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #144 (b03337d) into master (8fa05ed) will increase coverage by 2.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
+ Coverage   94.97%   97.75%   +2.78%     
==========================================
  Files          50       49       -1     
  Lines        3266     2991     -275     
==========================================
- Hits         3102     2924     -178     
+ Misses         90       37      -53     
+ Partials       74       30      -44     
Impacted Files Coverage Δ
yaml/secret.go 93.75% <ø> (+13.75%) ⬆️
yaml/service.go 82.60% <ø> (+11.18%) ⬆️
yaml/stage.go 100.00% <ø> (+33.33%) ⬆️
yaml/step.go 92.85% <ø> (+20.25%) ⬆️

@plyr4

This comment has been minimized.

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants