Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(worker-visibility): extend worker table with 5 fields #772

Merged
merged 31 commits into from
Jun 16, 2023

Conversation

KellyMerrick
Copy link
Contributor

@KellyMerrick KellyMerrick commented Feb 27, 2023

Worker Visibility Proposal: go-vela/community#813

dependent on go-vela/types#277
needed for go-vela/worker#482

@KellyMerrick KellyMerrick self-assigned this Feb 27, 2023
api/metrics.go Show resolved Hide resolved
api/metrics.go Outdated Show resolved Hide resolved
api/metrics.go Show resolved Hide resolved
api/metrics.go Outdated Show resolved Hide resolved
api/metrics.go Show resolved Hide resolved
database/worker/worker_test.go Show resolved Hide resolved
router/middleware/worker/worker_test.go Show resolved Hide resolved
router/middleware/worker/worker_test.go Show resolved Hide resolved
router/middleware/worker/worker_test.go Show resolved Hide resolved
router/middleware/worker/worker_test.go Show resolved Hide resolved
api/worker.go Outdated Show resolved Hide resolved
api/worker.go Outdated Show resolved Hide resolved
api/worker.go Outdated Show resolved Hide resolved
api/worker.go Outdated Show resolved Hide resolved
api/worker.go Outdated Show resolved Hide resolved
database/worker/worker_test.go Show resolved Hide resolved
database/worker/worker_test.go Show resolved Hide resolved
router/middleware/worker/worker_test.go Show resolved Hide resolved
router/middleware/worker/worker_test.go Show resolved Hide resolved
router/middleware/worker/worker_test.go Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

api/worker.go|328 col 5| w.SetStatus undefined (type *library.Worker has no field or method SetStatus)
api/worker.go|328 col 21| input.GetStatus undefined (type *library.Worker has no field or method GetStatus)
api/worker.go|328 col 21| too many errors) (typecheck)
api/metrics.go|450 col 19| worker.GetStatus undefined (type *library.Worker has no field or method GetStatus)
api/metrics.go|451 col 20| undefined: constants.WorkerStatusUnregistered
api/metrics.go|453 col 20| undefined: constants.WorkerStatusBusy
api/metrics.go|455 col 20| undefined: constants.WorkerStatusMaintenance
api/metrics.go|457 col 20| undefined: constants.WorkerStatusError
api/metrics.go|465 col 14| worker.GetStatus undefined (type *library.Worker has no field or method GetStatus)
api/metrics.go|465 col 39| undefined: constants.WorkerStatusUnregistered
api/worker.go|326 col 15| input.GetStatus undefined (type *library.Worker has no field or method GetStatus)
api/worker.go|328 col 5| w.SetStatus undefined (type *library.Worker has no field or method SetStatus)
api/worker.go|328 col 21| input.GetStatus undefined (type *library.Worker has no field or method GetStatus)
api/worker.go|328 col 21| too many errors (typecheck)

api/metrics.go Show resolved Hide resolved
api/metrics.go Outdated Show resolved Hide resolved
api/metrics.go Show resolved Hide resolved
api/metrics.go Outdated Show resolved Hide resolved
api/metrics.go Show resolved Hide resolved
api/metrics.go Outdated Show resolved Hide resolved
api/metrics.go Show resolved Hide resolved
api/metrics.go Outdated Show resolved Hide resolved
api/metrics.go Outdated Show resolved Hide resolved
api/worker.go Outdated Show resolved Hide resolved
@KellyMerrick KellyMerrick marked this pull request as ready for review April 26, 2023 20:09
@KellyMerrick KellyMerrick requested a review from a team as a code owner April 26, 2023 20:09
@KellyMerrick KellyMerrick marked this pull request as draft May 10, 2023 14:24
@KellyMerrick KellyMerrick changed the title feat(worker-availability): extend worker table with 4 fields feat(worker-visibility): extend worker table with 4 fields May 17, 2023
@KellyMerrick KellyMerrick changed the title feat(worker-visibility): extend worker table with 4 fields feat(worker-visibility): extend worker table with 5 fields Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #772 (60996b8) into main (e17c971) will decrease coverage by 0.04%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #772      +/-   ##
==========================================
- Coverage   71.36%   71.32%   -0.04%     
==========================================
  Files         303      303              
  Lines       12363    12371       +8     
==========================================
+ Hits         8823     8824       +1     
- Misses       3110     3116       +6     
- Partials      430      431       +1     
Impacted Files Coverage Δ
database/worker/table.go 100.00% <ø> (ø)
router/middleware/perm/perm.go 58.62% <12.50%> (-0.87%) ⬇️

@KellyMerrick KellyMerrick marked this pull request as ready for review June 14, 2023 14:36
api/worker.go Outdated Show resolved Hide resolved
database/worker/index_test.go Outdated Show resolved Hide resolved
router/middleware/perm/perm.go Show resolved Hide resolved
api/metrics.go Outdated Show resolved Hide resolved
@timhuynh94 timhuynh94 requested a review from ecrupper June 14, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants