-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(worker-visibility): extend worker table with 5 fields #772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
golangci
api/worker.go|328 col 5| w.SetStatus undefined (type *library.Worker has no field or method SetStatus)
api/worker.go|328 col 21| input.GetStatus undefined (type *library.Worker has no field or method GetStatus)
api/worker.go|328 col 21| too many errors) (typecheck)
api/metrics.go|450 col 19| worker.GetStatus undefined (type *library.Worker has no field or method GetStatus)
api/metrics.go|451 col 20| undefined: constants.WorkerStatusUnregistered
api/metrics.go|453 col 20| undefined: constants.WorkerStatusBusy
api/metrics.go|455 col 20| undefined: constants.WorkerStatusMaintenance
api/metrics.go|457 col 20| undefined: constants.WorkerStatusError
api/metrics.go|465 col 14| worker.GetStatus undefined (type *library.Worker has no field or method GetStatus)
api/metrics.go|465 col 39| undefined: constants.WorkerStatusUnregistered
api/worker.go|326 col 15| input.GetStatus undefined (type *library.Worker has no field or method GetStatus)
api/worker.go|328 col 5| w.SetStatus undefined (type *library.Worker has no field or method SetStatus)
api/worker.go|328 col 21| input.GetStatus undefined (type *library.Worker has no field or method GetStatus)
api/worker.go|328 col 21| too many errors (typecheck)
Codecov Report
@@ Coverage Diff @@
## main #772 +/- ##
==========================================
- Coverage 71.36% 71.32% -0.04%
==========================================
Files 303 303
Lines 12363 12371 +8
==========================================
+ Hits 8823 8824 +1
- Misses 3110 3116 +6
- Partials 430 431 +1
|
Worker Visibility Proposal: go-vela/community#813
dependent on go-vela/types#277
needed for go-vela/worker#482