Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(yaml): add go-yaml types package #1225

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

gci

0f94592
Select commit
Loading
Failed to load commit list.
Open

chore(yaml): add go-yaml types package #1225

gci
0f94592
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 19, 2024 in 1s

56.63% (target 90.00%)

View this Pull Request on Codecov

56.63% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 70.61366% with 340 lines in your changes missing coverage. Please review.

Project coverage is 56.63%. Comparing base (f6dd71e) to head (0f94592).

Files with missing lines Patch % Lines
compiler/types/yaml/buildkite/secret.go 72.72% 49 Missing and 2 partials ⚠️
compiler/types/yaml/buildkite/step.go 65.04% 35 Missing and 1 partial ⚠️
compiler/types/yaml/buildkite/template.go 43.75% 36 Missing ⚠️
compiler/types/yaml/buildkite/deployment.go 42.10% 33 Missing ⚠️
compiler/types/yaml/buildkite/service.go 65.90% 28 Missing and 2 partials ⚠️
compiler/types/yaml/buildkite/ruleset.go 81.81% 28 Missing ⚠️
compiler/types/yaml/buildkite/stage.go 19.23% 21 Missing ⚠️
compiler/types/yaml/buildkite/build.go 75.30% 18 Missing and 2 partials ⚠️
compiler/types/yaml/buildkite/metadata.go 66.10% 20 Missing ⚠️
compiler/types/yaml/buildkite/ulimit.go 80.61% 19 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
+ Coverage   56.19%   56.63%   +0.43%     
==========================================
  Files         609      622      +13     
  Lines       34124    35252    +1128     
==========================================
+ Hits        19176    19964     +788     
- Misses      14284    14616     +332     
- Partials      664      672       +8
Files with missing lines Coverage Δ
api/pipeline/template.go 0.00% <ø> (ø)
api/types/string.go 80.64% <ø> (ø)
compiler/native/clone.go 100.00% <ø> (ø)
compiler/native/compile.go 69.21% <ø> (ø)
compiler/native/environment.go 87.22% <ø> (ø)
compiler/native/expand.go 67.68% <ø> (ø)
compiler/native/initialize.go 100.00% <ø> (ø)
compiler/native/parse.go 85.36% <100.00%> (ø)
compiler/native/script.go 95.23% <ø> (ø)
compiler/native/substitute.go 70.00% <ø> (ø)
... and 34 more
View more details on Codecov