Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(yaml)!: allow for users to parse pipelines using old library #1220

Closed
wants to merge 5 commits into from

Merge branch 'main' into enhance/yaml-parser-flag

ef30880
Select commit
Loading
Failed to load commit list.
Closed

enhance(yaml)!: allow for users to parse pipelines using old library #1220

Merge branch 'main' into enhance/yaml-parser-flag
ef30880
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 3, 2024 in 0s

57.50% (target 90.00%)

View this Pull Request on Codecov

57.50% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 73.10726% with 341 lines in your changes missing coverage. Please review.

Project coverage is 57.50%. Comparing base (aa973fe) to head (ef30880).

Files with missing lines Patch % Lines
compiler/types/yaml/buildkite/secret.go 72.72% 49 Missing and 2 partials ⚠️
compiler/types/yaml/buildkite/template.go 43.75% 36 Missing ⚠️
compiler/types/yaml/buildkite/step.go 65.68% 34 Missing and 1 partial ⚠️
compiler/types/yaml/buildkite/service.go 65.90% 28 Missing and 2 partials ⚠️
compiler/types/yaml/buildkite/ruleset.go 81.81% 28 Missing ⚠️
compiler/template/starlark/render.go 38.46% 24 Missing ⚠️
compiler/types/yaml/buildkite/stage.go 19.23% 21 Missing ⚠️
compiler/types/yaml/buildkite/metadata.go 66.10% 20 Missing ⚠️
internal/yaml.go 81.48% 15 Missing and 5 partials ⚠️
compiler/types/yaml/buildkite/ulimit.go 80.61% 19 Missing ⚠️
... and 9 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1220      +/-   ##
==========================================
+ Coverage   56.91%   57.50%   +0.58%     
==========================================
  Files         599      611      +12     
  Lines       32904    34085    +1181     
==========================================
+ Hits        18727    19600     +873     
- Misses      13541    13835     +294     
- Partials      636      650      +14
Files with missing lines Coverage Δ
api/types/pipeline.go 100.00% <100.00%> (ø)
api/types/string.go 80.64% <ø> (ø)
compiler/native/clone.go 100.00% <ø> (ø)
compiler/native/compile.go 71.29% <100.00%> (+0.13%) ⬆️
compiler/native/environment.go 86.75% <ø> (ø)
compiler/native/initialize.go 100.00% <ø> (ø)
compiler/native/script.go 95.23% <ø> (ø)
compiler/native/substitute.go 70.00% <ø> (ø)
compiler/native/transform.go 95.34% <ø> (ø)
compiler/native/validate.go 96.93% <ø> (ø)
... and 33 more
View more details on Codecov