feat: adding a delete event #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1038 +/- ##
==========================================
+ Coverage 67.16% 67.30% +0.14%
==========================================
Files 330 330
Lines 14091 14118 +27
==========================================
+ Hits 9464 9502 +38
+ Misses 4148 4139 -9
+ Partials 479 477 -2
|
claire1618
changed the title
claire1618
changed the title
added 2 commits
January 18, 2024 11:58
ecrupper
requested changes
Jan 22, 2024
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the pull_request and push events, it would be beneficial if Vela could recognize the delete event. So the users would have the option to have Vela set off builds when a branch or tag are deleted in their repo.
The code added here takes the new changes I made in the types repo and takes in a delete webhook event to trigger a build.