Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): use only Vault API submodule #460

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Aug 20, 2024

As the library states here, we really should only be pulling in the API submodule. This really cleans up our dependencies and leverages Docker test clusters for our existing testing.

This also should reduce dependabot noise in general.

One thing of note, the tests do take a fair deal longer to run, so the testing timeout option may need adjusting in your setup.

@ecrupper ecrupper requested a review from a team as a code owner August 20, 2024 19:23
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.62%. Comparing base (479673e) to head (96d8d48).
Report is 1 commits behind head on main.

Files Patch % Lines
vault/vault.go 92.85% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   44.60%   45.62%   +1.02%     
==========================================
  Files           7        7              
  Lines         213      217       +4     
==========================================
+ Hits           95       99       +4     
  Misses        103      103              
  Partials       15       15              
Files Coverage Δ
vault/vault.go 59.57% <92.85%> (+3.76%) ⬆️

@ecrupper ecrupper merged commit fb00f2a into main Aug 20, 2024
10 of 12 checks passed
@ecrupper ecrupper deleted the chore/upgrade-vault branch August 20, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants