Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: allow key override and update deps #458

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

This change allows for the following pipeline

steps:
  - name: secrets
    image: target/secret-vault:latest
    secrets: [ vault_token ]
    parameters:
      log_level: trace
      auth_method: token
      items:
        - source: secret/vela/path/hello
          path: newPath
          keys:
            message: code

  - name: view message
    image: hub.docker.target.com/alpine:latest
    commands:
      - cat /vela/secrets/newPath/code # will print secret

Also went ahead and knocked out some deps

@ecrupper ecrupper requested a review from a team as a code owner August 20, 2024 18:08
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.60%. Comparing base (11e7d3a) to head (a1a2c7c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #458      +/-   ##
==========================================
+ Coverage   44.07%   44.60%   +0.52%     
==========================================
  Files           7        7              
  Lines         211      213       +2     
==========================================
+ Hits           93       95       +2     
  Misses        103      103              
  Partials       15       15              
Files Coverage Δ
cmd/secret-vault/read.go 92.00% <100.00%> (+0.33%) ⬆️

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 479673e into main Aug 20, 2024
10 of 12 checks passed
@ecrupper ecrupper deleted the enhance/key-override branch August 20, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants