Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update go to 1.17 #351

Merged
merged 8 commits into from
Aug 5, 2022
Merged

chore(deps): update go to 1.17 #351

merged 8 commits into from
Aug 5, 2022

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Dec 22, 2021

had some trouble with local integration test initially, but I think we're good now :)

@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #351 (b1caa65) into master (c81e8d4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   41.83%   41.83%           
=======================================
  Files           7        7           
  Lines         306      306           
=======================================
  Hits          128      128           
  Misses        160      160           
  Partials       18       18           

@wass3r wass3r marked this pull request as ready for review May 10, 2022 21:39
@wass3r wass3r requested a review from a team as a code owner May 10, 2022 21:39
delta592
delta592 previously approved these changes May 10, 2022
Copy link

@delta592 delta592 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

jbrockopp
jbrockopp previously approved these changes May 11, 2022
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile Outdated Show resolved Hide resolved
@wass3r wass3r dismissed stale reviews from jbrockopp and delta592 via 7ffab91 May 12, 2022 14:17
jbrockopp
jbrockopp previously approved these changes May 12, 2022
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wass3r
Copy link
Collaborator Author

wass3r commented Jun 29, 2022

sorry, will need a re-review.. had a conflict to solve with main branch

jbrockopp
jbrockopp previously approved these changes Jun 29, 2022
Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KellyMerrick KellyMerrick merged commit b20518b into master Aug 5, 2022
@KellyMerrick KellyMerrick deleted the chore/go branch August 5, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants