Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(admin): add oidc key rotation #326

Merged
merged 1 commit into from
Sep 6, 2024
Merged

enhance(admin): add oidc key rotation #326

merged 1 commit into from
Sep 6, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Sep 4, 2024

No description provided.

@ecrupper ecrupper requested a review from a team as a code owner September 4, 2024 14:27
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.38%. Comparing base (95ffb51) to head (c41ed0b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   89.30%   89.38%   +0.07%     
==========================================
  Files          21       21              
  Lines         851      857       +6     
==========================================
+ Hits          760      766       +6     
  Misses         55       55              
  Partials       36       36              
Files with missing lines Coverage Δ
vela/admin.go 95.18% <100.00%> (+0.30%) ⬆️
vela/client.go 91.08% <100.00%> (+0.04%) ⬆️

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 5c3dd6d into main Sep 6, 2024
9 of 11 checks passed
@ecrupper ecrupper deleted the admin/oidc branch September 6, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants