Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): upgrade types, server and yaml content type #317

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Jun 5, 2024

With the upgrade to gin, the SDK client needs to look for application/yaml as well as application/x-yaml when determining how to unmarshal data.

@ecrupper ecrupper requested a review from a team as a code owner June 5, 2024 20:02
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.30%. Comparing base (aed0973) to head (d1812ff).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
+ Coverage   89.29%   89.30%   +0.01%     
==========================================
  Files          21       21              
  Lines         850      851       +1     
==========================================
+ Hits          759      760       +1     
  Misses         55       55              
  Partials       36       36              
Files Coverage Δ
vela/client.go 91.04% <100.00%> (+0.04%) ⬆️

Copy link
Contributor

@wsan3 wsan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job!

@wsan3 wsan3 merged commit 8b70b90 into main Jun 5, 2024
10 of 11 checks passed
@wsan3 wsan3 deleted the chore/release/v24-rc1 branch June 5, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants