Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Delete unused /stream endpoints #215

Merged
merged 2 commits into from
Mar 27, 2023
Merged

chore: Delete unused /stream endpoints #215

merged 2 commits into from
Mar 27, 2023

Conversation

cognifloyd
Copy link
Member

This is the SDK side of this change: go-vela/server#799

@cognifloyd cognifloyd requested a review from a team as a code owner March 25, 2023 15:39
@codecov
Copy link

codecov bot commented Mar 25, 2023

Codecov Report

Merging #215 (98bc3ff) into main (e8d38c7) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   91.48%   91.38%   -0.11%     
==========================================
  Files          18       18              
  Lines        1374     1358      -16     
==========================================
- Hits         1257     1241      -16     
  Misses         86       86              
  Partials       31       31              
Impacted Files Coverage Δ
vela/service.go 94.91% <ø> (-0.61%) ⬇️
vela/step.go 94.91% <ø> (-0.61%) ⬇️

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wass3rw3rk wass3rw3rk merged commit 9c46e39 into main Mar 27, 2023
@wass3rw3rk wass3rw3rk deleted the drop-stream branch March 27, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants