Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): only set active when provided #575

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

Previously we were always setting w.Active to the result of the local active variable, which will be false if the user does not provide the active flag.

@ecrupper ecrupper requested a review from a team as a code owner September 19, 2024 14:13
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.52%. Comparing base (fcf8c86) to head (5f538d0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
command/worker/update.go 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
- Coverage   75.54%   75.52%   -0.03%     
==========================================
  Files         172      172              
  Lines        4462     4461       -1     
==========================================
- Hits         3371     3369       -2     
- Misses        855      856       +1     
  Partials      236      236              
Files with missing lines Coverage Δ
command/worker/update.go 66.66% <0.00%> (-6.07%) ⬇️

Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyyyy

@ecrupper ecrupper merged commit 53d3633 into main Sep 19, 2024
15 of 17 checks passed
@ecrupper ecrupper deleted the fix/worker-active-flag branch September 19, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants