Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipeline): better handle non-action event inputs #567

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

ecrupper
Copy link
Contributor

Also upgrade types, server, worker, sdk-go

@ecrupper ecrupper requested a review from a team as a code owner June 14, 2024 17:18
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 33 lines in your changes missing coverage. Please review.

Project coverage is 75.26%. Comparing base (68feb69) to head (38485fa).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   75.79%   75.26%   -0.53%     
==========================================
  Files         167      167              
  Lines        4325     4359      +34     
==========================================
+ Hits         3278     3281       +3     
- Misses        817      848      +31     
  Partials      230      230              
Files Coverage Δ
action/pipeline/validate.go 80.62% <21.42%> (-7.21%) ⬇️
action/pipeline/exec.go 0.00% <0.00%> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit dac42f3 into main Jun 14, 2024
14 of 16 checks passed
@ecrupper ecrupper deleted the fix/event-action-defaults branch June 14, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants