Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: syntax highlighting #563

Merged
merged 2 commits into from
Jun 7, 2024
Merged

fix: syntax highlighting #563

merged 2 commits into from
Jun 7, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Jun 6, 2024

fixing a couple things.

  • config load bug
  • help copy pasta
  • view settings missing color

@plyr4 plyr4 requested a review from a team as a code owner June 6, 2024 21:08
wass3rw3rk
wass3rw3rk previously approved these changes Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 75.79%. Comparing base (ce9383f) to head (c14334e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   75.78%   75.79%           
=======================================
  Files         167      167           
  Lines        4324     4325    +1     
=======================================
+ Hits         3277     3278    +1     
  Misses        817      817           
  Partials      230      230           
Files Coverage Δ
command/settings/view.go 60.00% <100.00%> (+2.85%) ⬆️
action/config/load.go 58.50% <0.00%> (ø)
cmd/vela-cli/main.go 0.00% <0.00%> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit 710f373 into main Jun 7, 2024
15 of 17 checks passed
@plyr4 plyr4 deleted the fix/color branch June 7, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants