-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: syntax highlighting for json/yaml #558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
==========================================
- Coverage 79.90% 78.88% -1.03%
==========================================
Files 161 162 +1
Lines 3982 4106 +124
==========================================
+ Hits 3182 3239 +57
- Misses 581 632 +51
- Partials 219 235 +16
|
ecrupper
approved these changes
Jun 5, 2024
wsan3
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wass3rw3rk
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented using https://github.com/alecthomas/chroma v2
adds a couple flags:
VELA_COLOR
- enable/disable colorVELA_COLOR_FORMAT
- sets the formatter (terminal
,terminal256
, etc, see chroma)VELA_COLOR_THEME
- sets the color theme (monokai
,onedark
, etc, see chroma)putting this out early to get some feedback but i still need to add some tests and better user flag options etc
json - monokai theme
yaml - nord theme