Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete legacy allow event fields and use nested worker types #546

Merged
merged 17 commits into from
Apr 8, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Apr 3, 2024

@plyr4 plyr4 requested a review from a team as a code owner April 3, 2024 18:57
action/repo/table.go Show resolved Hide resolved
action/repo/table.go Show resolved Hide resolved
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 73.58491% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 81.53%. Comparing base (a70862b) to head (a631229).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
- Coverage   82.00%   81.53%   -0.48%     
==========================================
  Files         147      147              
  Lines        3584     3568      -16     
==========================================
- Hits         2939     2909      -30     
- Misses        474      484      +10     
- Partials      171      175       +4     
Files Coverage Δ
action/repo/table.go 100.00% <100.00%> (ø)
action/secret/secret.go 80.00% <ø> (ø)
action/secret/table.go 100.00% <100.00%> (ø)
action/secret/validate.go 100.00% <100.00%> (ø)
action/worker/table.go 100.00% <100.00%> (ø)
action/worker/update.go 100.00% <100.00%> (ø)
command/secret/add.go 75.00% <100.00%> (ø)
command/secret/update.go 75.00% <100.00%> (ø)
action/repo/add.go 89.47% <50.00%> (-4.82%) ⬇️
action/repo/update.go 94.73% <50.00%> (-5.27%) ⬇️
... and 2 more

@wsan3
Copy link
Contributor

wsan3 commented Apr 3, 2024

In the go.mod, could you reference the latest commit in types?

action/secret/validate.go Outdated Show resolved Hide resolved
action/secret/validate.go Outdated Show resolved Hide resolved
@plyr4 plyr4 changed the title chore: delete legacy allow event fields chore: delete legacy allow event fields and use nested worker types Apr 3, 2024
action/secret/validate.go Outdated Show resolved Hide resolved
action/secret/validate.go Outdated Show resolved Hide resolved
@plyr4 plyr4 marked this pull request as draft April 5, 2024 19:00
@plyr4 plyr4 marked this pull request as ready for review April 5, 2024 19:16
action/secret/validate.go Outdated Show resolved Hide resolved
@ecrupper ecrupper merged commit 63d5835 into main Apr 8, 2024
14 of 17 checks passed
@ecrupper ecrupper deleted the chore/delete-legacy-events branch April 8, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants