Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployments): support commas in values for deploy parameters #526

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Feb 7, 2024

urfave CLI does not support maps natively, and so KV pairs supplied cannot contain any commas or the library will consider that a separator for the StringSlice type.

I've seen some code in the urfave library that suggests v3 might contain support for this?

Either way, a file type input solves this and I also think it's useful in other regards.

@ecrupper ecrupper requested a review from a team as a code owner February 7, 2024 16:14
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (c8476c7) 82.40% compared to head (f91caa7) 82.23%.
Report is 1 commits behind head on main.

❗ Current head f91caa7 differs from pull request most recent head fb5712a. Consider uploading reports for the commit fb5712a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #526      +/-   ##
==========================================
- Coverage   82.40%   82.23%   -0.18%     
==========================================
  Files         147      147              
  Lines        3580     3602      +22     
==========================================
+ Hits         2950     2962      +12     
- Misses        466      473       +7     
- Partials      164      167       +3     
Files Coverage Δ
action/deployment/add.go 91.30% <100.00%> (-2.99%) ⬇️
command/deployment/add.go 78.18% <71.42%> (-12.30%) ⬇️

@ecrupper ecrupper merged commit 05b0d75 into main Feb 7, 2024
14 of 15 checks passed
@ecrupper ecrupper deleted the fix/deployments/support-commas branch February 7, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants