Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(version): Remove invalid flag from help text #525

Merged
merged 1 commit into from
Feb 7, 2024
Merged

chore(version): Remove invalid flag from help text #525

merged 1 commit into from
Feb 7, 2024

Conversation

tmapes
Copy link
Contributor

@tmapes tmapes commented Feb 6, 2024

This flag is not supported in the version command (though it would be nice to supply a Vela server and retrieve the version of the server).

@tmapes tmapes requested a review from a team as a code owner February 6, 2024 16:54
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, you're right.

vela --api.addr <url> version works (not in the way you want though)

the way the help text prints it definitely does not work.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8476c7) 82.40% compared to head (3c62cc6) 82.40%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   82.40%   82.40%           
=======================================
  Files         147      147           
  Lines        3580     3580           
=======================================
  Hits         2950     2950           
  Misses        466      466           
  Partials      164      164           
Files Coverage Δ
command/version/version.go 86.66% <ø> (ø)

@wass3rw3rk wass3rw3rk merged commit b39b30a into go-vela:main Feb 7, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants