Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding branch field to scheduled builds #472

Merged
merged 5 commits into from
Aug 28, 2023

Conversation

claire1618
Copy link
Contributor

No description provided.

@claire1618 claire1618 requested a review from a team as a code owner August 25, 2023 16:36
Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny thing then LGTM

&cli.StringFlag{
EnvVars: []string{"VELA_BRANCH", "SCHEDULE_BRANCH"},
Name: "branch",
Aliases: []string{"e"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Aliases: []string{"e"},
Aliases: []string{"b"},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed!

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #472 (e5a471f) into main (dc6c700) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #472   +/-   ##
=======================================
  Coverage   86.35%   86.36%           
=======================================
  Files         145      145           
  Lines        6304     6308    +4     
=======================================
+ Hits         5444     5448    +4     
  Misses        704      704           
  Partials      156      156           
Files Changed Coverage Δ
action/schedule/add.go 93.47% <100.00%> (+0.14%) ⬆️
action/schedule/table.go 100.00% <100.00%> (ø)
action/schedule/update.go 100.00% <100.00%> (ø)
command/schedule/add.go 89.65% <100.00%> (+0.36%) ⬆️
command/schedule/update.go 89.65% <100.00%> (+0.36%) ⬆️

@claire1618 claire1618 merged commit 86a70ff into main Aug 28, 2023
@claire1618 claire1618 deleted the enhance/scheduledBuildBranches branch August 28, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants