Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: worker registration #438

Merged
merged 5 commits into from
Apr 18, 2023
Merged

fix: worker registration #438

merged 5 commits into from
Apr 18, 2023

Conversation

wass3rw3rk
Copy link
Member

  • make manual request to worker registration endpoint
  • update dependencies

@wass3rw3rk wass3rw3rk marked this pull request as ready for review April 18, 2023 20:52
@wass3rw3rk wass3rw3rk requested a review from a team as a code owner April 18, 2023 20:52
@codecov
Copy link

codecov bot commented Apr 18, 2023 •
edited
Loading

Codecov Report

Merging #438 (a397704) into main (d77d1db) will decrease coverage by 0.08%.
The diff coverage is 77.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
- Coverage   86.04%   85.96%   -0.08%     
==========================================
  Files         133      133              
  Lines        5768     5800      +32     
==========================================
+ Hits         4963     4986      +23     
- Misses        660      666       +6     
- Partials      145      148       +3
Impacted Files Coverage Δ
action/worker/add.go 88.75% <77.50%> (-11.25%) ⬇️

ecrupper
ecrupper previously approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

KellyMerrick
KellyMerrick approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wass3rw3rk wass3rw3rk merged commit 3bad979 into main Apr 18, 2023
@wass3rw3rk wass3rw3rk deleted the fix/worker branch April 18, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecrupper ecrupper ecrupper approved these changes

@KellyMerrick KellyMerrick KellyMerrick approved these changes

@timhuynh94 timhuynh94 timhuynh94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wass3rw3rk @timhuynh94 @KellyMerrick @ecrupper