Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new version pkg #168

Merged
merged 6 commits into from
Oct 19, 2020
Merged

feat: use new version pkg #168

merged 6 commits into from
Oct 19, 2020

Conversation

jbrockopp
Copy link
Contributor

Dependent on go-vela/types#112

Updating to the new go-vela/types/version package to improve the information provided surrounding the application.

If I compile the binary specifically for the OS on my workstation, I'm met with this from the --version flag:

$ release/darwin/amd64/vela --version
vela version v0.6.0

Here is the output from the new vela version command:

$ release/darwin/amd64/vela version
{
  Canonical: v0.6.0,
  Major: 0,
  Minor: 6,
  Patch: 0,
  PreRelease: ,
  Metadata: {
    Architecture: amd64,
    BuildDate: 2020-10-16T10:31:00Z,
    Compiler: gc,
    GitCommit: 569cb7079f941747d96e5603a468eac2d8d8fa61,
    GoVersion: 1.15.2,
    OperatingSystem: darwin,
  }
}

NOTE: This also updates the release.sh script used in GitHub Actions pipelines to use our make commands for building the binaries.

@jbrockopp jbrockopp self-assigned this Oct 16, 2020
@jbrockopp jbrockopp added enhancement Indicates an improvement to a feature feature Indicates a new feature labels Oct 16, 2020
@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #168 into master will decrease coverage by 0.58%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   88.19%   87.61%   -0.59%     
==========================================
  Files         102      103       +1     
  Lines        2093     2107      +14     
==========================================
  Hits         1846     1846              
- Misses        160      174      +14     
  Partials       87       87              
Impacted Files Coverage Δ
action/version.go 0.00% <0.00%> (ø)

@jbrockopp jbrockopp marked this pull request as ready for review October 19, 2020 12:44
@jbrockopp jbrockopp requested a review from a team as a code owner October 19, 2020 12:44
Copy link

@kneal kneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐬

@kneal kneal merged commit 65043c7 into master Oct 19, 2020
@kneal kneal deleted the feat/version branch October 19, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature feature Indicates a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants