Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use docker buildx to build multi-platform images #941

Merged
merged 3 commits into from
Aug 14, 2023
Merged

Use docker buildx to build multi-platform images #941

merged 3 commits into from
Aug 14, 2023

Conversation

manastyretskyi
Copy link
Contributor

Closes #940

ARolek
ARolek requested changes Aug 12, 2023
View reviewed changes
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! I just have one minor request and then a clarification. Thanks for the quick turn around.

.github/workflows/on_release_publish.yml Show resolved Hide resolved
.github/workflows/on_release_publish.yml Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Aug 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 8f25368ee-PR-941

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.906%
Totals Coverage Status
Change from base Build 7e316eb16: 0.0%
Covered Lines: 6556
Relevant Lines: 13977
💛 - Coveralls

ARolek
ARolek approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The CI is failing, but I believe that's due to PRs not have access to secrets. I'm going to merge and give it a run.

Thanks for the contibution!

@ARolek ARolek merged commit e1c9b43 into go-spatial:master Aug 14, 2023
7 of 8 checks passed
@ARolek
Copy link
Member

ARolek commented Aug 14, 2023

Looks like the build is successful!

image

I will get a version cut this week so we can use a version tag other than edge.

@jchamberlain jchamberlain mentioned this pull request Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ARolek ARolek ARolek approved these changes

@gdey gdey Awaiting requested review from gdey gdey is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Push images for more architectures to Docker Hub registry
3 participants
@manastyretskyi @coveralls @ARolek