MapLibre - Vue3 - Vite Migration v2 #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build dcb237d0f-PR-926
💛 - Coveralls |
iwpnd
suggested changes
May 11, 2023
There was a problem hiding this comment.
i checked out the PR, build and tested the viewer and did not find anything out of the ordinary. seems to be working just right.
some nitpicks. i would like to get rid of traces of mapbox in the naming and clean up comments that are still there left an right. but thats about it.
looks good 👍
| @@ -6,7 +6,7 @@ | |||
| import { store, mutations } from "@/globals/store"; | |||
| import { mapSetters } from "@/globals/map"; | |||
| import ToggleTileBoundariesControl from "./MapboxControls"; | |||
| import mapboxgl from "mapbox-gl"; | |||
| import mapboxgl from "maplibre-gl"; | |||
|
|
|||
| export default { | |||
| name: "ViewerMapbox", | |||
mapl
force-pushed
the
ui-deps-migration-v2
branch
from
40a8a53
to
eafe3a6
Compare
|
@iwpnd it looks like all your comments have been addressed. Would you mark the PR approved if you don't have any additional change requests? |
ARolek
force-pushed
the
ui-deps-migration-v2
branch
from
eafe3a6
to
bd4f62e
Compare
iwpnd
approved these changes
Jun 9, 2023
|
my bad, wasn't aware that I was appointed a reviewer and was blocking this |
|
@iwpnd no worries! I just want to get your approval as you have worked on this part of the codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone, this is my 2nd attempt to migrate the internal UI Viewer project.
All the UI (dev) libraries have been updated to the most recent versions.
Mapbox -> MapLibre
Vue2 -> Vue3
Vue Cli -> Vite