Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: comment hana connection string #920

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

iwpnd
Copy link
Member

@iwpnd iwpnd commented Mar 29, 2023

As per @mrylov comment here: https://github.com/go-spatial/tegola/pull/893\#discussion_r1136602372 the connection string is exposed on purpose. Let's comment for future reference.

@iwpnd iwpnd requested review from gdey and ARolek as code owners March 29, 2023 06:52
@coveralls
Copy link

Pull Request Test Coverage Report for Build 73f57ab69-PR-920

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.894%

Totals Coverage Status
Change from base Build 928406e7a: 0.0%
Covered Lines: 6553
Relevant Lines: 13974

💛 - Coveralls

Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ARolek ARolek merged commit 62bfffe into go-spatial:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants