Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: read config from stdin #802

Merged
merged 1 commit into from
Sep 13, 2021
Merged

config: read config from stdin #802

merged 1 commit into from
Sep 13, 2021

Conversation

ear7h
Copy link
Contributor

@ear7h ear7h commented Aug 13, 2021

This feature is helpful for running configs generated from another command (like dhall-toml 👀).

The - is an idiomatic alias for stdin used in commands like curl and grep.

@ear7h ear7h requested review from ARolek and gdey as code owners August 13, 2021 23:48
@coveralls
Copy link

coveralls commented Aug 13, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 9309a3b32-PR-802

  • 2 of 5 (40.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 45.025%
Changes Missing Coverage Covered Lines Changed/Added Lines %
config/config.go 0 3 0.0%
Totals Coverage Status
Change from base Build e444ac0b8: -0.007%
Covered Lines: 5435
Relevant Lines: 12071
💛 - Coveralls

Base automatically changed from issue-799 to v0.14.x August 18, 2021 21:57
@gdey
Copy link
Member

gdey commented Aug 18, 2021

@ear7h will review after #801 on Friday if I have time left.

@ARolek
Copy link
Member

ARolek commented Sep 7, 2021

@ear7h can you rebase this with v0.14.x? LGTM otherwise.

@ear7h ear7h force-pushed the config-stdin branch 2 times, most recently from 4dae47a to c93e0fb Compare September 10, 2021 01:36
@ear7h
Copy link
Contributor Author

ear7h commented Sep 10, 2021

@ARolek done, and I improved the cli help text to help feature discovery

ARolek
ARolek approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@ARolek ARolek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ear7h ear7h merged commit 4f4ca6d into v0.14.x Sep 13, 2021
@ear7h ear7h deleted the config-stdin branch September 13, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ARolek ARolek ARolek approved these changes

@gdey gdey Awaiting requested review from gdey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ear7h @coveralls @gdey @ARolek