Fix nil pointer dereference when using implicit zooms #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ying to local variable
Pull Request Test Coverage Report for Build 965
💛 - Coveralls |
Pull Request Test Coverage Report for Build 964
💛 - Coveralls |
|
@ear7h can you add a test to prove the bug and that it's handled? We like to make sure all bug reports have an associated test to avoid the issue in the future. |
|
@ARolek will do |
pnorman
suggested changes
Apr 2, 2018
There was a problem hiding this comment.
I built with 6029db7 and I still get an error
$ ~/go/src/github.com/go-spatial/tegola/cmd/tegola/tegola serve
2018-04-01 17:37:02 [INFO] config.go:203: loading local config (config.toml)
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x55933f5ba760]
goroutine 1 [running]:
panic(0x55933fc198a0, 0xc4200140d0)
/usr/lib/go-1.7/src/runtime/panic.go:500 +0x1a1
github.com/go-spatial/tegola/config.(*Config).Validate(0x559340310680, 0xb, 0x0)
/home/pnorman/go/src/github.com/go-spatial/tegola/config/config.go:108 +0x2b0
github.com/go-spatial/tegola/cmd/tegola/cmd.initConfig()
/home/pnorman/go/src/github.com/go-spatial/tegola/cmd/tegola/cmd/root.go:71 +0xf5
github.com/go-spatial/tegola/cmd/tegola/cmd.glob..func3(0x5593402b7dc0, 0x55934032d8a0, 0x0, 0x0)
/home/pnorman/go/src/github.com/go-spatial/tegola/cmd/tegola/cmd/server.go:21 +0x45
github.com/go-spatial/tegola/vendor/github.com/spf13/cobra.(*Command).execute(0x5593402b7dc0, 0x55934032d8a0, 0x0, 0x0, 0x5593402b7dc0, 0x55934032d8a0)
/home/pnorman/go/src/github.com/go-spatial/tegola/vendor/github.com/spf13/cobra/command.go:702 +0x4a3
github.com/go-spatial/tegola/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x5593402b7ba0, 0x0, 0x5593402b7dc0, 0xc420199ef0)
/home/pnorman/go/src/github.com/go-spatial/tegola/vendor/github.com/spf13/cobra/command.go:783 +0x377
github.com/go-spatial/tegola/vendor/github.com/spf13/cobra.(*Command).Execute(0x5593402b7ba0, 0x0, 0x0)
/home/pnorman/go/src/github.com/go-spatial/tegola/vendor/github.com/spf13/cobra/command.go:736 +0x2b
main.main()
/home/pnorman/go/src/github.com/go-spatial/tegola/cmd/tegola/main.go:13 +0x31
|
LGTM. @pnorman when you have a moment can you give this a test with your problematic config? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #386
Fix to apply layer MaxZoom and MinZoom to underlying config. Was applying to local variable