Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tile cache middleware not receiving response code 200 #263

Closed
ARolek opened this issue Jan 16, 2018 · 0 comments
Closed

Tile cache middleware not receiving response code 200 #263

ARolek opened this issue Jan 16, 2018 · 0 comments
Assignees
@ARolek
Milestone
v0.6.0

Comments

@ARolek
Copy link
Member

ARolek commented Jan 16, 2018

When a tile is successfully generated the tile cache middleware is suppose to intercept the response and decide if the tile should be persisted in the cache. It does this by looking or a response code of 200 (http.StatusOK). This was implemented in #251 but appears to have created a regression where 200 responses are not being written correctly and therefore the cache is not being populated.
@ARolek ARolek added this to the v0.6.0 milestone Jan 16, 2018
@ARolek ARolek self-assigned this Jan 16, 2018
ARolek added a commit that referenced this issue Jan 17, 2018
@ARolek
fixed issue where cache was not being leveraged if 200 status was not…
8cbf2b0 
… being set correctly on map and layer tile requests. added tests to catch the issue in the future. closes #263
@ARolek ARolek mentioned this issue Jan 17, 2018
Merged
ARolek added a commit that referenced this issue Jan 17, 2018
@ARolek
middleware cache test cases. #263
15fc40e
@ARolek ARolek closed this as completed Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ARolek ARolek

Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

No branches or pull requests
1 participant
@ARolek