Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This should be cf.ID == nil and not cf.ID != nil #195

Closed
gdey opened this issue Nov 25, 2017 · 1 comment
Closed

This should be cf.ID == nil and not cf.ID != nil #195

gdey opened this issue Nov 25, 2017 · 1 comment
Assignees
@gdey
Labels
good first issue

Comments

@gdey
Copy link
Member

gdey commented Nov 25, 2017

https://github.com/terranodo/tegola/blob/30dac10f813543493ab8a0479ec7a806ddd86f1f/mvt/layer.go#L154-L158

This will cause a runtime panic because we are guaranteeing that cf.ID is going to be nil, before dereferencing it. It's obvious that this is a typo, and should have been cf.ID == nil.
@gdey gdey self-assigned this Nov 25, 2017
gdey added a commit that referenced this issue Dec 2, 2017
@gdey
Quick fix for issue #195
a3f43cf 
There was a small typo that could cause a nil derefrence.
gdey added a commit that referenced this issue Dec 3, 2017
@gdey
[issue-195] Added test case.
0015924 
Added test case for Issue #195.
Without the fix for #195 this will fail via a panic.
gdey added a commit that referenced this issue Dec 3, 2017
@gdey
[issue-195] Quick fix for issue #195
0ca29da 
There was a small typo that could cause a nil derefrence.
@gdey gdey mentioned this issue Dec 3, 2017
Merged
JivanAmara added a commit that referenced this issue Dec 6, 2017
@JivanAmara
Merge pull request #206 from terranodo/issue-195
de7ef0f 
Issue #195
gdey added a commit that referenced this issue Dec 6, 2017
@gdey
Update CHANGELOG.md
97041f5 
Added entry for fixing #195
@gdey
Copy link
Member Author

gdey commented Dec 6, 2017

The issue has been merged into v0.5.0

@gdey gdey closed this as completed Dec 6, 2017
ARolek added a commit that referenced this issue Dec 6, 2017
@ARolek
added additional tests to mvt.LayerAddFeatures #195
9e36574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gdey gdey

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gdey