configurable tile buffer #107
Comments
|
I hope it also solves problem like this (road cuts at adjoining tiles)
|
|
Yes, I would say those issues are related to the title buffer. The buffer is not big enough. |
|
I no longer think it's because the tile buffer is not big enough. I think this has to do with the geometries we are grabbing before clipping. These geometries are the ones within a bounding box defined by the z/x/y tile. We then expand that bounding box the buffer size and clip the geometries to that new bounding box. Unfortunately, this means we don't grab all possible geometries that could be there in the newly expanded bounding box. (The Purple geometries in the figure.) I believe this is leading to the jagged edges we see as alluded to by this StackOverflow post.
What we should be doing is expanding the bounding box by the buffer, and grab all the geometries in that new bounding box. We just clip to that bounding box as well. |
|
Anyone have an isolated dataset for this issue? I think I have a solution; that I need to test. |
|
@gdey Do you have a solution on github branch which I can pull from? I want to test it. |
|
@sagarr Not yet, I'll push up as soon as I have figured out a bug (that I introduced when making changes for this issue), then ping you. |
This fix does not make the size of the tile buffer available in the config file. We believe the reason for some of the jagged lines that occurs has to do with features that are missing from the buffer region of the tile. When grabbing features to display, we were only grabbing feature that intersected the bounding box of the tile, instead of the bounding box of the tile plus a buffer zone. We query for all the features we need, including the ones that only intersect with the buffer zone. Some of the issues reported in #107, we believe is caused by these miscalculated bounding boxes. Additional clean up is required to remove unused code.
This fix does not make the size of the tile buffer available in the config file. We believe the reason for some of the jagged lines that occurs has to do with features that are missing from the buffer region of the tile. When grabbing features to display, we were only grabbing feature that intersected the bounding box of the tile, instead of the bounding box of the tile plus a buffer zone. We query for all the features we need, including the ones that only intersect with the buffer zone. Some of the issues reported in #107, we believe is caused by these miscalculated bounding boxes. Additional clean up is required to remove unused code.
This fix does not make the size of the tile buffer available in the config file. We believe the reason for some of the jagged lines that occurs has to do with features that are missing from the buffer region of the tile. When grabbing features to display, we were only grabbing feature that intersected the bounding box of the tile, instead of the bounding box of the tile plus a buffer zone. We query for all the features we need, including the ones that only intersect with the buffer zone. Some of the issues reported in #107, we believe is caused by these miscalculated bounding boxes. Additional clean up is required to remove unused code.
|
@sagarr I just pushed up a branch called issue-107. Please try that branch out. I still have a few failing tests there, and some clean up to do. But you should be able to test it. |
|
This issue has been merged into the v0.6.0 branch and will be included in the next release. You can give it a test by pulling down the branch and building from source. |
One of the issues being reported during geometry clipping (#56) is a rendering fragment due to the lack of tile buffer. Vector tiles use a "hack" where the tile buffer extends beyond the tile extent. This allows for a smooth transition between tiles. An example of the issue can be seen in the attached screenshot.
The text was updated successfully, but these errors were encountered: