Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite setup instuctions in Readme for clarity #60

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

adamakhtar
Copy link
Contributor

This PR makes the setup instructions a little more explicit to help avoid any confusion (especially for OSM / Tegola beginners ).

Impetus for this PR comes from the discussion on this issue #59 (comment)

This originally started out as a personal blog post but I decided to just rewrite it and submit it as a PR. If its a little too verbose I have no problem with it being rejected or modified to suit the project's needs.

@ARolek
Copy link
Member

ARolek commented Jan 25, 2021

@adamakhtar thanks for keeping this PR going, and apologies for the slow action on my end. I'm starting to make some updates to the documentation for tegola and I will get this in the queue. Your efforts are very much appreciated!

@adamakhtar
Copy link
Contributor Author

@ARolek ahh I just realised my last commit shouldn't have been on this branch. Let me remove that and repush. I'll do that today or in the next few days.

@adamakhtar
Copy link
Contributor Author

@ARolek related to my last comment, can I remove the last commit and force push the branch back up? Doesn't make sense for it to be part of this projects commit history.

@ARolek
Copy link
Member

ARolek commented Feb 3, 2021

@adamakhtar a force push should be fine.

@adamakhtar
Copy link
Contributor Author

@ARolek I have force pushed and the unwanted commit is no longer present. Sorry for the bother.

@ARolek
Copy link
Member

ARolek commented Feb 23, 2021

Thank you for the contribution! Sorry I was so slow to go through this, but your enhancements are very much appreciated.

@ARolek ARolek merged commit cb2e78d into go-spatial:master Feb 23, 2021
@adamakhtar
Copy link
Contributor Author

Awesome, thanks @ARolek !

@adamakhtar adamakhtar deleted the update-readme branch March 1, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants