Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ineffectual assignment to parentIndex #19

Merged
merged 1 commit into from
Dec 24, 2023
Merged

fix: ineffectual assignment to parentIndex #19

merged 1 commit into from
Dec 24, 2023

Conversation

Monirzadeh
Copy link

fix golangci-lint error ineffectual assignment to parentIndex (ineffassign)

@Monirzadeh Monirzadeh changed the title fix neffectual assignment to parentIndex fix: ineffectual assignment to parentIndex Dec 24, 2023
@Monirzadeh Monirzadeh marked this pull request as draft December 24, 2023 11:56
fmartingr
fmartingr approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I need to setup the workflows CI for this, will try to replicate shiori's workflows as much as possible.

@Monirzadeh Monirzadeh marked this pull request as ready for review December 24, 2023 18:41
@Monirzadeh Monirzadeh merged commit 2b0d15c into go-shiori:main Dec 24, 2023
4 checks passed
@Monirzadeh Monirzadeh deleted the update-unit-test branch December 25, 2023 07:07
@Monirzadeh Monirzadeh added this to the v1.3.0 milestone Dec 25, 2023
@Monirzadeh Monirzadeh self-assigned this Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmartingr fmartingr fmartingr approved these changes

Assignees

@Monirzadeh Monirzadeh

Labels
None yet
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Monirzadeh @fmartingr