Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with not setting Sec-WebSocket-Key header. #964

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Fix bug with not setting Sec-WebSocket-Key header. #964

merged 1 commit into from
Oct 26, 2023

Conversation

pydima
Copy link
Contributor

@pydima pydima commented Oct 26, 2023

Development guide

Link

Test on local before making the PR

go run ./lib/utils/simple-check

Sorry, made a bug in previous PR.

@pydima
Copy link
Contributor Author

pydima commented Oct 26, 2023

Hmm, seems like pipeline failure is not relevant to the change.

@ysmood ysmood merged commit 3522cb9 into go-rod:main Oct 26, 2023
5 of 6 checks passed
@ysmood
Copy link
Member

ysmood commented Oct 26, 2023

Yes, the network is not stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants