Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix input type month #920

Merged
merged 1 commit into from
Aug 21, 2023
Merged

fix input type month #920

merged 1 commit into from
Aug 21, 2023

Conversation

madflow
Copy link
Contributor

@madflow madflow commented Aug 20, 2023 •
edited
Loading

@ysmood ysmood enabled auto-merge (squash) August 20, 2023 16:03
@ysmood
Copy link
Member

ysmood commented Aug 21, 2023 •
edited
Loading

Please fix the CI error:

element_test.go:334: "16:06" ⦗not ==⦘ "16:6"

https://github.com/go-rod/rod/actions/runs/5916817262/job/16047573808?pr=920

auto-merge was automatically disabled August 21, 2023 08:01

Head branch was pushed to by a user without write access

@madflow
Copy link
Contributor Author

madflow commented Aug 21, 2023

@ysmood I amended the way now is constructed in order to have a more predictive test, and fixed the assertion. Tests pass locally - lets wait for CI.

@ysmood ysmood enabled auto-merge (squash) August 21, 2023 08:21
@ysmood ysmood disabled auto-merge August 21, 2023 08:21
@ysmood ysmood merged commit 0b4f067 into go-rod:main Aug 21, 2023
6 checks passed
@madflow madflow deleted the fix/input-time branch August 21, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysmood ysmood ysmood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madflow @ysmood