Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to prevent launching twice. #910

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Conversation

kvii
Copy link
Contributor

@kvii kvii commented Jul 27, 2023

Add an atomic.Bool flag to launcher.Launcher. I will return a friendly err rather than panic.

My English is not good. Please be careful of my code comment.

我英语不太好,注释啥的请严格检查一下。

lib/launcher/launcher.go Outdated Show resolved Hide resolved
@ysmood ysmood merged commit 7fae9b3 into go-rod:main Jul 29, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants