Fix request/response logging for SetDoNotParseResponse(true)

[kon3gor]

Bug fix for #829

Changes

• responseLogger is not middleware anymore for consistency reasons
• responseLogger is now being called whenever execute exits
• Parameter name in SetDoNotParseResponse has been changed to notParse

[jeevatkm]

@kon3gor Thanks for creating a PR. The code updates LGTM, can you please check test failures and code conflicts?

[kon3gor]

@jeevatkm Tests and merge conflicts are fixed now🫡

[jeevatkm]

@kon3gor Thanks for taking care of the tests. It seems the errors.Join method is causing a failure on tests. Since it's added in go1.20, but resty supports go min version 1.19

Please see https://github.com/go-resty/resty/pull/836/checks

[kon3gor]

@jeevatkm Hi! I've removed erros.Join and replaced it with the self-made replica. Also made some logic fixes for logging logging errors.

[kon3gor]

@jeevatkm Looks like errors.Is logic has been changed for joinError support. In go1.19 there was no Unwrap []error interface, that why my custom joinErr doesn't work. I'll change logic a bit to match this old behaviour

[jeevatkm]

@kon3gor Okay, please let me know when you are done.

Also, please add attribution to the code for the method Join.

// Code obtained from `golang:src/errors/join.go` to backfill until Resty go minimum version gets updated to go1.20
// TODO: Remove this Join-related code.

[jeevatkm]

@kon3gor I was giving it a second thought on the go minimum version. Let's update the go minimum version to go1.20.

Please update go.mod and GitHub CI actions files. Then, you can work on the logic update in line with the go1.20 and above version.

[codecov]

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.85%. Comparing base (c22b968) to head (72da0db).
Report is 1 commits behind head on v2.

Files with missing lines	Patch %	Lines
client.go	90.90%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               v2     #836      +/-   ##
==========================================
- Coverage   96.89%   96.85%   -0.05%     
==========================================
  Files          14       14              
  Lines        1773     1780       +7     
==========================================
+ Hits         1718     1724       +6     
- Misses         35       36       +1     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jeevatkm]

@kon3gor Thanks for updating PR and test cases.