-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update log level to warning for errors within retry block #587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandyydk Thanks for your PR and contribution. I'm sorry for the delayed attention on the PR.
Can you resolve the code conflicts?
Sure will update this. Thanks for the response. |
@sandyydk Just wanted to check. Are you planning to update this PR? if not let me know, I will take it up and prepare for next release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sandyydk Thanks for you PR, appreciated.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
==========================================
- Coverage 95.73% 95.68% -0.05%
==========================================
Files 11 11
Lines 1571 1600 +29
==========================================
+ Hits 1504 1531 +27
Misses 41 41
- Partials 26 28 +2
☔ View full report in Codecov by Sentry. |
Closes #561
Closes #554