Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Content-Type support for SetFileReader #111

Closed
wants to merge 2 commits into from

Conversation

gh0st42
Copy link

@gh0st42 gh0st42 commented Dec 21, 2017

Simple solution to set content type for multipart filereader parts. Default resty behaviour of "application/octet-stream" still present if no content-type is given.

@codecov
Copy link

codecov bot commented Dec 21, 2017

Codecov Report

Merging #111 into master will decrease coverage by 0.83%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   96.96%   96.12%   -0.84%     
==========================================
  Files          10       10              
  Lines         987     1006      +19     
==========================================
+ Hits          957      967      +10     
- Misses         16       25       +9     
  Partials       14       14
Impacted Files Coverage Δ
client.go 97.62% <100%> (ø) ⬆️
util.go 93.81% <100%> (+0.63%) ⬆️
request.go 94.76% <30.76%> (-5.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba6ff5...5ddc912. Read the comment docs.

@jeevatkm
Copy link
Member

@gh0st42 Thanks for the PR. While looking at your PR, I think we can do better for SetFileReader and SetFile together with backward compatibility.

Let me create a PR, then you can have a look and we can improve it.

@gh0st42
Copy link
Author

gh0st42 commented Dec 21, 2017

Sounds good, if you have a special testing branch this would also be fine and I'd be happy to test it. I guess for a general solution that can be applied to SetFileReader as well as SetFile a bit more work has to be done since currently they are implemented both a bit different in resty.

@jeevatkm
Copy link
Member

Closing this PR infavour of generic implementation 513d3b0

@jeevatkm jeevatkm closed this Jan 23, 2018
@jeevatkm jeevatkm added this to the v1.1 Milestone milestone Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants