Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose response reader without reading response #87

Closed
perdasilva opened this issue Aug 4, 2017 · 13 comments
Closed

Expose response reader without reading response #87

perdasilva opened this issue Aug 4, 2017 · 13 comments
Assignees
Labels

Comments

@perdasilva
Copy link

I would like to get access to the response reader without the response first being read by resty. This would allow me to stream (e.g. to stdout) the response as it comes, rather than resty buffering it until it finishes.

@jeevatkm jeevatkm self-assigned this Aug 11, 2017
@jeevatkm
Copy link
Member

@perdasilva Thanks for creating an issue, once done I will ping you.

@jeevatkm
Copy link
Member

@perdasilva I would like to know how soon you need this feature. Based on that I will plan it. Please let me know.

@adeanzan
Copy link

@jeevatkm - I am also interested in this feature and need it to continue with a project I'm working on.

@jeevatkm
Copy link
Member

@adeanzan Thank you

@jeevatkm jeevatkm modified the milestone: v1.0 Milestone Aug 13, 2017
@perdasilva
Copy link
Author

ASAP would be great. As it is now, we are mixing b/w resty and net/http. Would be nice to just rely on resty ^^

@perdasilva
Copy link
Author

Thx for picking this feature up ^^

@jeevatkm
Copy link
Member

@perdasilva @adeanzan Thanks, understood. Once branch is ready I will ping you. So that you can try before merging into master.

@jeevatkm
Copy link
Member

jeevatkm commented Aug 14, 2017

@perdasilva @adeanzan I have added this feature on branch expose-response-body of commit 6a77f10

// Method available at Client and Request level
SetDoNotParseResponse(bool)

To get the body io.ReadCloser call response.RawBody()

Please refer to methods godoc. I look forward to feedback and improvements.

@jeevatkm
Copy link
Member

@perdasilva @adeanzan Did you get a chance to try it out? Awaiting your feedback then I will merge it master.

@adeanzan
Copy link

@jeevatkm Just gave it a try and it worked great! I appreciate the quick implementation.

@jeevatkm
Copy link
Member

@adeanzan Thanks for the feedback.

@perdasilva
Copy link
Author

Shit dude, I'm so sorry - I totally missed your tag on the previous message. Thank you for implementing the change!!!

@jeevatkm
Copy link
Member

That's okay @perdasilva. Give it try and let me know, its currently on master; not yet released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants